[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

[Sunil K via Phabricator via cfe-commits]

koops added inline comments.


================
Comment at: clang/lib/Basic/CMakeLists.txt:4
   TargetParser
+  FrontendOpenMP
   )
----------------
koops wrote:
> ABataev wrote:
> > What requires this new dependency?
> When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries are built instead of archive libraries in lib/ directory. 
> Then, I was getting this error:
> `Error in linking libclangBasic.so.18git because getOpenMPClauseName() is not defined.` 
> 
> While linking the .o files to form libFrontendOpenMP.so, `OMP.cpp.o` is also included which has the function definition of `getOpenMPClauseName()`.  Hence there was a need to have libFrontendOpenMP.so in the link line of libclangBasic.so.18git.
The error `Error in linking libclangBasic.so.18git because getOpenMPClauseName() is not defined.` was seen on ppc64le and can be reproduced on other platforms using -DBUILD_SHARED_LIBS=1 in the cmake command line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123235/new/

https://reviews.llvm.org/D123235