[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

Tue Nov 21 08:30:17 PST 2023

alanphipps added a comment.

In D138846#4657193 <https://reviews.llvm.org/D138846#4657193>, @zequanwu wrote:

> In D138846#4657175 <https://reviews.llvm.org/D138846#4657175>, @hans wrote:
>
>> We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to this commit. I think Zequan is investigating: https://bugs.chromium.org/p/chromium/issues/detail?id=1503919
>
> It turns out to be that our rust code with old version of rustc without this change, so mixture of raw profile versions are used, causing segment fault.

Thank you for the update! Is this also the case of the issue @glandium reports above as well?  I think both issues manifested as a ValueProf issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138846/new/

https://reviews.llvm.org/D138846