[llvm] [lld] [lldb] [compiler-rt] [mlir] [clang] [flang] [libcxx] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

Rik Huijzer via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 20 12:21:50 PST 2023


================
@@ -1143,6 +1143,8 @@ void OpEmitter::genAttrNameGetters() {
       const char *const getAttrName = R"(
   assert(index < {0} && "invalid attribute index");
   assert(name.getStringRef() == getOperationName() && "invalid operation name");
+  assert(!name.getAttributeNames().empty() && "empty attribute names. Is a new "
----------------
rikhuijzer wrote:

Good tip. Thanks! I've implemented it and verified that it is triggered when reverting the fix from this PR (`func::FuncDialect` in `dependentDialects`).

https://github.com/llvm/llvm-project/pull/72801


More information about the cfe-commits mailing list