[clang] [CUDA][HIP] ignore implicit host/device attr for override (PR #72815)

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 20 06:24:56 PST 2023


================
@@ -1000,13 +1000,9 @@ void Sema::checkCUDATargetOverload(FunctionDecl *NewFD,
     // should have the same implementation on both sides.
     if (NewTarget != OldTarget &&
         ((NewTarget == CFT_HostDevice &&
-          !(LangOpts.OffloadImplicitHostDeviceTemplates &&
-            isCUDAImplicitHostDeviceFunction(NewFD) &&
-            OldTarget == CFT_Device)) ||
+          !isCUDAImplicitHostDeviceFunction(NewFD)) ||
----------------
yxsamliu wrote:

actually we do not need this part of change to fix this issue, since this part only affects overloading. As we fixed the overloading/overriding differentiation, this part is not needed. I have removed this part in the updated change.

https://github.com/llvm/llvm-project/pull/72815


More information about the cfe-commits mailing list