[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added a comment.

GCC only ever defines __riscv_32e



================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:210
+    if (Is64Bit)
+      Builder.defineMacro("__riscv_64e");
+    else
----------------
Ugh, these don't align with the normal pattern. __riscv_e already exists in the spec, can we just leave __riscv_32e as deprecated for RV32E and not introduce the old-style __riscv_64e?


================
Comment at: clang/lib/Basic/Targets/RISCV.h:139
     if (Name == "ilp32" || Name == "ilp32f" || Name == "ilp32d") {
       ABI = Name;
       return true;
----------------
Does it matter we don't undo the effects of the RVE ABI here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70401/new/

https://reviews.llvm.org/D70401