[clang] [OpenACC] Implement compound construct parsing (PR #72692)

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 17 13:09:37 PST 2023


================
@@ -22,7 +22,9 @@ using namespace llvm;
 
 namespace {
 
-// Translate single-token string representations to the OpenACC Directive Kind.
+// This doesn't completely comprehend 'Compound Constructs' (as it just
+// identifies the first token) just the first token of each.  So
+// this should only be used by `ParseOpenACCDirectiveKind`.
 OpenACCDirectiveKind GetOpenACCDirectiveKind(StringRef Name) {
----------------
alexey-bataev wrote:

Missed ёрш in the previous reviews, better to name it `getOpenACCDirectiveKind`

https://github.com/llvm/llvm-project/pull/72692


More information about the cfe-commits mailing list