[clang] 3ce5c04 - Replace getAs with castAs, dyn_cast with cast (NFC) (#72600)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 17 09:22:39 PST 2023
Author: Mike Rice
Date: 2023-11-17T09:22:33-08:00
New Revision: 3ce5c04ad0585e5e14ba9d2f594492a257edf7b1
URL: https://github.com/llvm/llvm-project/commit/3ce5c04ad0585e5e14ba9d2f594492a257edf7b1
DIFF: https://github.com/llvm/llvm-project/commit/3ce5c04ad0585e5e14ba9d2f594492a257edf7b1.diff
LOG: Replace getAs with castAs, dyn_cast with cast (NFC) (#72600)
Make the code clear that nullptrs are not expected.
Added:
Modified:
clang/lib/AST/ASTContext.cpp
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
Removed:
################################################################################
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 4f54791b4c1e5ce..1c893d008cb49f3 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -4014,8 +4014,8 @@ QualType ASTContext::getVectorType(QualType vecType, unsigned NumElts,
assert(vecType->isBuiltinType() ||
(vecType->isBitIntType() &&
// Only support _BitInt elements with byte-sized power of 2 NumBits.
- llvm::isPowerOf2_32(vecType->getAs<BitIntType>()->getNumBits()) &&
- vecType->getAs<BitIntType>()->getNumBits() >= 8));
+ llvm::isPowerOf2_32(vecType->castAs<BitIntType>()->getNumBits()) &&
+ vecType->castAs<BitIntType>()->getNumBits() >= 8));
// Check if we've already instantiated a vector of this type.
llvm::FoldingSetNodeID ID;
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index ad6b0188390d88f..d04645e89f92843 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -4402,7 +4402,7 @@ static void updateNVPTXMetadata(Function &Kernel, StringRef Name, int32_t Value,
// Update the "maxntidx" metadata for NVIDIA, or add it.
MDNode *ExistingOp = getNVPTXMDNode(Kernel, Name);
if (ExistingOp) {
- auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
+ auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
int32_t OldLimit = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
ExistingOp->replaceOperandWith(
2, ConstantAsMetadata::get(ConstantInt::get(
@@ -4441,7 +4441,7 @@ OpenMPIRBuilder::readThreadBoundsForKernel(const Triple &T, Function &Kernel) {
}
if (MDNode *ExistingOp = getNVPTXMDNode(Kernel, "maxntidx")) {
- auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
+ auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
int32_t UB = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
return {0, ThreadLimit ? std::min(ThreadLimit, UB) : UB};
}
More information about the cfe-commits
mailing list