[clang-tools-extra] 7aaa86b - [include-cleaner] Add regression tests for outliving File&Source Manager
Kadir Cetinkaya via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 17 02:33:38 PST 2023
Author: Kadir Cetinkaya
Date: 2023-11-17T11:32:51+01:00
New Revision: 7aaa86b28ddc3deded6e357b27f2bbebb97a3864
URL: https://github.com/llvm/llvm-project/commit/7aaa86b28ddc3deded6e357b27f2bbebb97a3864
DIFF: https://github.com/llvm/llvm-project/commit/7aaa86b28ddc3deded6e357b27f2bbebb97a3864.diff
LOG: [include-cleaner] Add regression tests for outliving File&Source Manager
Added:
Modified:
clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp b/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
index dfefa66887b0f24..0f2ded5f1834531 100644
--- a/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
+++ b/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
@@ -558,5 +558,35 @@ TEST_F(PragmaIncludeTest, ExportInUnnamedBuffer) {
PI.getExporters(llvm::cantFail(FM->getFileRef("foo.h")), *FM),
testing::ElementsAre(llvm::cantFail(FM->getFileRef("exporter.h"))));
}
+
+TEST_F(PragmaIncludeTest, OutlivesFMAndSM) {
+ Inputs.Code = R"cpp(
+ #include "public.h"
+ )cpp";
+ Inputs.ExtraFiles["public.h"] = R"cpp(
+ #include "private.h"
+ #include "private2.h" // IWYU pragma: export
+ )cpp";
+ Inputs.ExtraFiles["private.h"] = R"cpp(
+ // IWYU pragma: private, include "public.h"
+ )cpp";
+ Inputs.ExtraFiles["private2.h"] = R"cpp(
+ // IWYU pragma: private
+ )cpp";
+ build(); // Fills up PI, file/source manager used is destroyed afterwards.
+ Inputs.MakeAction = nullptr; // Don't populate PI anymore.
+
+ // Now this build gives us a new File&Source Manager.
+ TestAST Processed = build();
+ auto &FM = Processed.fileManager();
+ auto PrivateFE = FM.getFile("private.h");
+ assert(PrivateFE);
+ EXPECT_EQ(PI.getPublic(PrivateFE.get()), "\"public.h\"");
+
+ auto Private2FE = FM.getFile("private2.h");
+ assert(Private2FE);
+ EXPECT_THAT(PI.getExporters(Private2FE.get(), FM),
+ testing::ElementsAre(llvm::cantFail(FM.getFileRef("public.h"))));
+}
} // namespace
} // namespace clang::include_cleaner
More information about the cfe-commits
mailing list