[clang] [llvm] [clang-tools-extra] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

Greg Clayton via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 15 11:24:17 PST 2023


================
@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() {
 
 lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp,
                                            ListenerSP listener_sp,
-                                           const FileSpec *crash_file_path,
+                                           FileSP crash_file_sp,
                                            bool can_connect) {
   lldb::ProcessSP process_sp;
-  if (crash_file_path == NULL)
+  if (crash_file_sp)
----------------
clayborg wrote:

The logic is inverted from what it used to be, this should be:
```
if (!crash_file_sp)
```

https://github.com/llvm/llvm-project/pull/71769


More information about the cfe-commits mailing list