[lldb] [clang-tools-extra] [clang] [llvm] Add new API in SBTarget for loading core from SBFile (PR #71769)
Greg Clayton via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 15 11:24:15 PST 2023
================
@@ -194,11 +194,12 @@ void ProcessGDBRemote::Terminate() {
PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance);
}
-lldb::ProcessSP ProcessGDBRemote::CreateInstance(
- lldb::TargetSP target_sp, ListenerSP listener_sp,
- const FileSpec *crash_file_path, bool can_connect) {
+lldb::ProcessSP ProcessGDBRemote::CreateInstance(lldb::TargetSP target_sp,
+ ListenerSP listener_sp,
+ lldb::FileSP crash_file_sp,
+ bool can_connect) {
lldb::ProcessSP process_sp;
- if (crash_file_path == nullptr)
+ if (crash_file_sp)
----------------
clayborg wrote:
The logic is inverted from what it used to be, this should be:
```
if (!crash_file_sp)
```
https://github.com/llvm/llvm-project/pull/71769
More information about the cfe-commits
mailing list