[clang] [clang] Stub out gcc_struct attribute (PR #71148)

[John McCall via cfe-commits]

================
@@ -5031,7 +5031,12 @@ void RecordDecl::completeDefinition() {
 /// This which can be turned on with an attribute, pragma, or the
 /// -mms-bitfields command-line option.
 bool RecordDecl::isMsStruct(const ASTContext &C) const {
-  return hasAttr<MSStructAttr>() || C.getLangOpts().MSBitfields == 1;
+  if (hasAttr<MSStructAttr>())
+    return true;
+  if (hasAttr<GCCStructAttr>())
+    return false;
+  return C.getLangOpts().MSBitfields.value_or(
----------------
rjmccall wrote:

I always prefer to have less complicated logic in the options types, because I've seen it get out of hand.  I don't feel too strongly about this, though, and I do see how you have uses of the components feeding into it.

https://github.com/llvm/llvm-project/pull/71148