[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

Wed Nov 15 05:52:54 PST 2023

dzhidzhoev added a comment.

In D144006#4656399 <https://reviews.llvm.org/D144006#4656399>, @aeubanks wrote:

> In D144006#4656383 <https://reviews.llvm.org/D144006#4656383>, @dzhidzhoev wrote:
>
>> In D144006#4656371 <https://reviews.llvm.org/D144006#4656371>, @aeubanks wrote:
>>
>>> Is there any issue with mixing IR built with `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that ThinLTO is mixing Rust and Clang IR which set that differently.
>>
>> Apparently, it's an issue with ThinLTO that might be caused by a change in MetadataLoader https://github.com/llvm/llvm-project/pull/68986.
>> Is there a way to get a repro like this one https://bugs.chromium.org/p/chromium/issues/detail?id=1487910#c3 if it's not too complicated?
>
> I've shared the repro tar with your commit email address, sorry it's so big. I tried linking again with the revert and now it looks like the debug info verifier is firing instead. Do you also need a repro tar with everything built with the revert?

Thank you so much! I think that's enough.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144006/new/

https://reviews.llvm.org/D144006