[llvm] [clang] [clang-tools-extra] [MCP] Enhance MCP copy Instruction removal for special case (PR #70778)

via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 15 03:00:10 PST 2023


================
@@ -163,7 +163,8 @@ class CopyTracker {
 
   /// Clobber a single register, removing it from the tracker's copy maps.
   void clobberRegister(MCRegister Reg, const TargetRegisterInfo &TRI,
-                       const TargetInstrInfo &TII, bool UseCopyInstr) {
+                       const TargetInstrInfo &TII, bool UseCopyInstr,
+                       bool CleanUp = false) {
----------------
qcolombet wrote:

Could you add a comment for the `CleanUp` argument?

In particular, we need to make it clear why and when this argument needs to be set to true.
Without any explanation, I would expect that we need to actually set it to true all the time.

https://github.com/llvm/llvm-project/pull/70778


More information about the cfe-commits mailing list