[clang-tools-extra] [llvm] [clang] [nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata (PR #71328)
Mingming Liu via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 13 15:54:37 PST 2023
================
@@ -435,13 +450,195 @@ static void writeInstrProfile(StringRef OutputFilename,
}
}
-static void
-mergeInstrProfile(const WeightedFileVector &Inputs, StringRef DebugInfoFilename,
- SymbolRemapper *Remapper, StringRef OutputFilename,
- ProfileFormat OutputFormat, uint64_t TraceReservoirSize,
- uint64_t MaxTraceLength, int MaxDbgCorrelationWarnings,
- bool OutputSparse, unsigned NumThreads, FailureMode FailMode,
- const StringRef ProfiledBinary) {
+// Common options.
----------------
minglotus-6 wrote:
Sounds reasonable to me. I moved options definitions right after `cl::Subcommand`.
https://github.com/llvm/llvm-project/pull/71328
More information about the cfe-commits
mailing list