https://github.com/erichkeane commented: This seems fine to me, but I think @efriedma-quic /the weak ODR discussion needs to be finalized before this can be accepted. https://github.com/llvm/llvm-project/pull/71706