[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 10 09:55:40 PST 2023


PiotrZSL added a comment.

This change is dangerous, it depends that elements/iterators won't be re-allocated/invalidated during insertion process.
Part with removing double lookup in IncludeSorter::addInclude looks fine, but part that involve IncludeBucket is problematic.
I will try to push part that involve IncludeLocations optimizations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117460/new/

https://reviews.llvm.org/D117460



More information about the cfe-commits mailing list