[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 21:33:10 PST 2023


MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607
+    // compiler has broken.
+    assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid");
+    assert((!EndLoc || EndLoc->isValid()) && "End location is not valid");
----------------
Is this workaround still needed after b0e61de7075942ef5ac8af9ca1ec918317f62152 (with a test `clang/test/Coverage/unresolved-ctor-expr.cpp`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147073/new/

https://reviews.llvm.org/D147073



More information about the cfe-commits mailing list