[clang-tools-extra] [clang-tidy] Improve `container-data-pointer` check to use `c_str()` (PR #71304)
Piotr Zegar via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 9 00:23:20 PST 2023
================
@@ -111,16 +115,18 @@ void ContainerDataPointerCheck::check(const MatchFinder::MatchResult &Result) {
MemberExpr>(CE))
ReplacementText = "(" + ReplacementText + ")";
- if (CE->getType()->isPointerType())
- ReplacementText += "->data()";
- else
- ReplacementText += ".data()";
+ ReplacementText += CE->getType()->isPointerType() ? "->" : ".";
+ ReplacementText += CStrMethod ? "c_str()" : "data()";
+
+ std::string Description =
----------------
PiotrZSL wrote:
use llvm::StringRef instead of std::string here
https://github.com/llvm/llvm-project/pull/71304
More information about the cfe-commits
mailing list