[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 16:43:20 PST 2023


efriedma-quic wrote:

Why are we creating a comdat here in the first place?  Creating a comdat associated with an internal symbol doesn't do anything useful: an internal symbol can't be defined in any other translation unit, so the comdat will never be discarded.

If we allow creating a comdat associated with an internal symbol, the backend should handle it correctly; it's a bug if it crashes like you've described.  (I'm not sure how to reproduce the crash with your testcase, though.)

https://github.com/llvm/llvm-project/pull/71748


More information about the cfe-commits mailing list