[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

Mikael Holmén via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 01:16:20 PST 2023


uabelho added a comment.

Btw, a bit confusing (to me at least) to reopen this review since it's already landed.



================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:450
+    case OMPC_unknown:
+    default:
+      return "unknown";
----------------
Adding "default:" here silences the warning.
But looks like @ABataev commented on something similar earlier and said that's not recommended?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123235/new/

https://reviews.llvm.org/D123235



More information about the cfe-commits mailing list