[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 10:27:40 PST 2023


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12694-12695
+      SourceLocation DisplayLocation =
+          ((FailParameter == OMPC_unknown) ? FC->getBeginLoc()
+                                           : FC->getFailParameterLoc());
+      if ((FailParameter != OMPC_acq_rel) && (FailParameter != OMPC_acquire) &&
----------------
Remove extra parens


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12696-12698
+      if ((FailParameter != OMPC_acq_rel) && (FailParameter != OMPC_acquire) &&
+          (FailParameter != OMPC_relaxed) && (FailParameter != OMPC_release) &&
+          (FailParameter != OMPC_seq_cst))
----------------
Remove extra parens, LLVM does not use this style


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123235/new/

https://reviews.llvm.org/D123235



More information about the cfe-commits mailing list