[clang] [clang][analyzer] Improve StdLibraryFunctionsChecker 'readlink' modeling. (PR #71373)

via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 08:10:49 PST 2023


https://github.com/DonatNagyE requested changes to this pull request.

Sorry for undoing my approval, but as I was reviewing your other commit #71392  I noticed that it includes a testcase (the change in clang/test/Analysis/std-c-library-functions-path-notes.c) that logically belongs to this commit.

Moreover, I think that TC shows that it would be useful to see the behavior of this change on open source projects as I fear that this change could lead to "technically TP, but not helpful for the user" reports.

Please move that TC into this commit and provide some open source results that show the behavior of this checker after this change.

https://github.com/llvm/llvm-project/pull/71373


More information about the cfe-commits mailing list