[clang] 24060db - Silence diagnostics about not all control paths returning a value; NFC

[Aaron Ballman via cfe-commits]

Author: Aaron Ballman
Date: 2023-11-07T10:42:50-05:00
New Revision: 24060db3a93297ca77abef8feae301af2e9163b5

URL: https://github.com/llvm/llvm-project/commit/24060db3a93297ca77abef8feae301af2e9163b5
DIFF: https://github.com/llvm/llvm-project/commit/24060db3a93297ca77abef8feae301af2e9163b5.diff

LOG: Silence diagnostics about not all control paths returning a value; NFC

Added: 
    

Modified: 
    clang/include/clang/AST/ExprCXX.h
    clang/lib/Analysis/FlowSensitive/SimplifyConstraints.cpp
    clang/lib/Sema/SemaExprCXX.cpp

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h
index 37d310ef967d9c0..24278016431837b 100644
--- a/clang/include/clang/AST/ExprCXX.h
+++ b/clang/include/clang/AST/ExprCXX.h
@@ -2397,6 +2397,7 @@ class CXXNewExpr final
     case CXXNewInitializationStyle::List:
       return true;
     }
+    llvm_unreachable("Unknown initializer");
   }
 
   /// The kind of initializer this new-expression has.

diff  --git a/clang/lib/Analysis/FlowSensitive/SimplifyConstraints.cpp b/clang/lib/Analysis/FlowSensitive/SimplifyConstraints.cpp
index decb928f218a81e..00a3104a57b6ba3 100644
--- a/clang/lib/Analysis/FlowSensitive/SimplifyConstraints.cpp
+++ b/clang/lib/Analysis/FlowSensitive/SimplifyConstraints.cpp
@@ -42,6 +42,7 @@ substitute(const Formula &F,
     return arena.makeEquals(substitute(*F.operands()[0], Substitutions, arena),
                             substitute(*F.operands()[1], Substitutions, arena));
   }
+  llvm_unreachable("Unknown formula kind");
 }
 
 // Returns the result of replacing atoms in `Atoms` with the leader of their

diff  --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index c07462aa2444403..67bc847ff2a60e6 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -2050,6 +2050,7 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal,
                                                   Initializer->getBeginLoc(),
                                                   Initializer->getEndLoc());
     }
+    llvm_unreachable("Unknown initialization kind");
   }();
 
   // C++11 [dcl.spec.auto]p6. Deduce the type which 'auto' stands in for.