[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

Mehdi Amini via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 05:54:34 PST 2023


joker-eph wrote:

> I've seen those exact test failures locally, but since precommit CI was fine, I landed this PR and kept a close eye on the bots.

If you see failures locally, it's best to understand where they coming from: even if it passes on bots it just means we have a hole in our test coverage.  
For the pre-commit CI, one thing to look for is a "positive signal" instead of the absence of "negative signal": that is checking in the log for a "success" for a given tests (depending on the config, tests can be marked "unsupported" or not executed for various reasons).
Thanks @zmodem for reporting the issue: we need to fix the premerge config!


https://github.com/llvm/llvm-project/pull/71322


More information about the cfe-commits mailing list