[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:3837-3838
     return nullptr;
-  return Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation());
+  OMPClause *Clause = Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation());
+  return Clause;
 }
----------------



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12684
+      }
+      const auto *FC = dyn_cast<OMPFailClause>(C);
+      OpenMPClauseKind FailParameter = FC->getFailParameter();
----------------



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12689-12693
+      if (!((FailParameter == OMPC_acq_rel) ||
+            (FailParameter == OMPC_acquire) ||
+            (FailParameter == OMPC_relaxed) ||
+            (FailParameter == OMPC_release) ||
+            (FailParameter == OMPC_seq_cst))) {
----------------



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:12693-12695
+            (FailParameter == OMPC_seq_cst))) {
+        Diag(DisplayLocation, diag::err_omp_atomic_fail_wrong_or_no_clauses);
+      }
----------------
No need for braces here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123235/new/

https://reviews.llvm.org/D123235