[clang] [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (PR #70056)

[via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/70056 at github.com>


DonatNagyE wrote:

I decided to keep the `reportOOB()` calls without additional changes. I feel that adding `std::move()` has limited benefits (performance impact is negligible and the next line is a `return` so the reader can already see that the variable won't be used again) and it would make those already long lines even more convoluted. I also considered refactoring the data flow, but I didn't find a more elegant arrangement than the current one.

https://github.com/llvm/llvm-project/pull/70056