[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

Jacob Lambert via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 11:02:03 PST 2023


================
@@ -155,10 +162,10 @@ class EmitAssemblyHelper {
     return F;
   }
 
-  void
-  RunOptimizationPipeline(BackendAction Action,
+  void RunOptimizationPipeline(BackendAction Action,
                           std::unique_ptr<raw_pwrite_stream> &OS,
-                          std::unique_ptr<llvm::ToolOutputFile> &ThinLinkOS);
+                          std::unique_ptr<llvm::ToolOutputFile> &ThinLinkOS,
+                          BackendConsumer *BC);
----------------
lamb-j wrote:

I think so? I'm using the same indentation level as the other arguments, and BackendConsumer needs it's own line to no not overflow the character limit. What looks off about it?

https://github.com/llvm/llvm-project/pull/69371


More information about the cfe-commits mailing list