[libunwind] [llvm] [clang-tools-extra] [clang] [libcxx] [libc++] Allow running the test suite with optimizations (PR #68753)

via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 5 16:44:42 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff e3c2eacfd8b95346cfa4e71ba08b91cab124047b 8499198a4d7b3b1e269f843ee71108cb6d7fc03c -- libcxx/test/support/escape.h libunwind/test/libunwind_02.pass.cpp libunwind/test/unw_resume.pass.cpp libunwind/test/unwind_leaffunction.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libunwind/test/libunwind_02.pass.cpp b/libunwind/test/libunwind_02.pass.cpp
index 499cc3b69ab3..32cbd40fb7cb 100644
--- a/libunwind/test/libunwind_02.pass.cpp
+++ b/libunwind/test/libunwind_02.pass.cpp
@@ -18,7 +18,8 @@
 #define EXPECTED_NUM_FRAMES 50
 #define NUM_FRAMES_UPPER_BOUND 100
 
-__attribute__((noinline)) _Unwind_Reason_Code callback(_Unwind_Context *context, void *cnt) {
+__attribute__((noinline)) _Unwind_Reason_Code callback(_Unwind_Context *context,
+                                                       void *cnt) {
   (void)context;
   int *i = (int *)cnt;
   ++*i;
@@ -36,10 +37,11 @@ __attribute__((noinline)) void test_backtrace() {
   }
 }
 
-// These functions are effectively the same, but we have to be careful to avoid unwanted
-// optimizations that would mess with the number of frames we expect. Surprisingly,
-// slapping `noinline` is not sufficient -- we also have to avoid writing the function
-// in a way that the compiler can easily spot tail recursion.
+// These functions are effectively the same, but we have to be careful to avoid
+// unwanted optimizations that would mess with the number of frames we expect.
+// Surprisingly, slapping `noinline` is not sufficient -- we also have to avoid
+// writing the function in a way that the compiler can easily spot tail
+// recursion.
 __attribute__((noinline)) int test1(int i);
 __attribute__((noinline)) int test2(int i);
 
diff --git a/libunwind/test/unwind_leaffunction.pass.cpp b/libunwind/test/unwind_leaffunction.pass.cpp
index 6e6d9a0ed80d..9187368c66d0 100644
--- a/libunwind/test/unwind_leaffunction.pass.cpp
+++ b/libunwind/test/unwind_leaffunction.pass.cpp
@@ -24,7 +24,8 @@
 #include <unistd.h>
 #include <unwind.h>
 
-__attribute__((noinline)) _Unwind_Reason_Code frame_handler(struct _Unwind_Context* ctx, void* arg) {
+__attribute__((noinline)) _Unwind_Reason_Code
+frame_handler(struct _Unwind_Context *ctx, void *arg) {
   (void)arg;
   Dl_info info = { 0, 0, 0, 0 };
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/68753


More information about the cfe-commits mailing list