[clang] [clang-tools-extra] [llvm] [libc] [flang] [mlir] [compiler-rt] [libcxx] [mlir][spirv] Implement gpu::TargetAttrInterface (PR #69949)

Jacques Pienaar via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 5 11:34:24 PST 2023


================
@@ -15,6 +15,7 @@
 
 #include "Utils.h"
 #include "mlir/Dialect/GPU/IR/GPUDialect.h"
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
----------------
jpienaar wrote:

This feels off: you have GPU dialect transforms depending on SPIRV attributes/dialect (esp in header). Why is this pass in GPU dialect rather than SPIRV one?

https://github.com/llvm/llvm-project/pull/69949


More information about the cfe-commits mailing list