[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)
Timm Baeder via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 5 09:26:31 PST 2023
================
@@ -2388,15 +2389,20 @@ class CXXNewExpr final
/// Whether this new-expression has any initializer at all.
bool hasInitializer() const {
- return CXXNewExprBits.StoredInitializationStyle > 0;
+ switch (getInitializationStyle()) {
+ case CXXNewInitializationStyle::None:
+ return true;
+ case CXXNewInitializationStyle::Implicit:
+ case CXXNewInitializationStyle::Call:
+ case CXXNewInitializationStyle::List:
+ return false;
+ }
----------------
tbaederr wrote:
```suggestion
return getInitializationStyle() != CXXNewInitializationStyele::None;
```
(Isn't the logic of that code right now inverted?)
https://github.com/llvm/llvm-project/pull/71322
More information about the cfe-commits
mailing list