[clang] [clang-repl] [test] Make an XFAIL more precise (PR #70991)

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 15:01:53 PDT 2023


mstorsjo wrote:

> FTR, the "Worker" tab on that buildbot page will point you to the maintainer.

Ah, there it is, I tried looking around, but overlooked that one...

> But tagging me is also fine in general.

Ok, thanks!

> I'm unable to repro the problem locally because my local build doesn't seem to include clang-repl.exe, so the whole clang/test/Interpreter directory is Unsupported. Is there some cmake parameter to enable JIT?

Not sure - by doing `ninja clang-repl` I was able to get those tests running at least.

> If you want to XFAIL specifically for the Sony targets, what you suggested would work. I'm unclear about the "MSVC C++ ABI" aspect, but if that gets the test to work, go for it.

Ok, great, thanks! I'll try that and reland the commit.

https://github.com/llvm/llvm-project/pull/70991


More information about the cfe-commits mailing list