[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 12:27:36 PDT 2023


hvdijk added a comment.

In D86310#4656024 <https://reviews.llvm.org/D86310#4656024>, @Fznamznon wrote:

> Hi there,
>
> This change seems to be causing assertion failure in clang when a struct contains a _BitInt with length longer than 128 - https://godbolt.org/z/4jTrW4fcP .

Thanks for the report. This is a pre-existing problem for `i128:128` targets -- the same assertion failure can be seen, without this change, for the same program with e.g. `--target=aarch64 -Xclang -fexperimental-max-bitint-width=1024` -- so I don't think it's a problem in this change directly, but considering X86 is the only target that enables >128-bit bit integers by default, it became far more visible after this change and because of that, more important to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86310/new/

https://reviews.llvm.org/D86310



More information about the cfe-commits mailing list