[clang] [clang-tools-extra] [clang][NFC] Refactor `clang::Linkage` (PR #71049)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 04:50:06 PDT 2023


================
@@ -2214,7 +2214,7 @@ void ASTWriter::WriteDeclAbbrevs() {
   Abv->Add(BitCodeAbbrevOp(0));                       // TSCSpec
   Abv->Add(BitCodeAbbrevOp(0));                       // InitStyle
   Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
-  Abv->Add(BitCodeAbbrevOp(0));                       // Linkage
+  Abv->Add(BitCodeAbbrevOp(1));                         // Linkage
----------------
Endilll wrote:

@ChuanqiXu9 confirmed that touching this is fine (thank you!). If I guess correctly that this value corresponds to `Linkage::None` we have in some default constructors, we should consider changing that default to `Linkage::Invalid`.

`Linkage::None` being default feels like we computed the linkage and arrived at `Linkage::None` even when it's not the case.

CC @AaronBallman 

https://github.com/llvm/llvm-project/pull/71049


More information about the cfe-commits mailing list