[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 04:29:26 PDT 2023


ArcsinX added a comment.

> One such heuristic is to check the nodes in the selection tree for the exact line match

It looks like this heuristic doesn't work well in multiline cases.
E.g.

  int
  f^unc() {
    return 0;
  }

will give empty result with  this patch applied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159497/new/

https://reviews.llvm.org/D159497



More information about the cfe-commits mailing list