[clang] 3bc056d - [clang-repl] [test] Make an XFAIL more precise (#70991)

via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 00:51:37 PDT 2023


Author: Martin Storsjö
Date: 2023-11-02T09:51:33+02:00
New Revision: 3bc056d5f0ebe9e4074afa088c3a0355f9ab901a

URL: https://github.com/llvm/llvm-project/commit/3bc056d5f0ebe9e4074afa088c3a0355f9ab901a
DIFF: https://github.com/llvm/llvm-project/commit/3bc056d5f0ebe9e4074afa088c3a0355f9ab901a.diff

LOG: [clang-repl] [test] Make an XFAIL more precise (#70991)

The const.cpp testcase fails when running in MSVC mode, while it does
succeed in MinGW mode.

In MSVC mode, there are more constructor invocations than expected, as
the printout looks like this:

    A(1), this = 0000025597930000
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1

While the expected printout looks like this:

    A(1), this = 000002C903E10000
    f: this = 000002C903E10000, val = 1
    f: this = 000002C903E10000, val = 1
    ~A, this = 000002C903E10000, val = 1

Added: 
    

Modified: 
    clang/test/Interpreter/const.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/Interpreter/const.cpp b/clang/test/Interpreter/const.cpp
index 4b6ce65e3643e64..1412a1d85d6f58f 100644
--- a/clang/test/Interpreter/const.cpp
+++ b/clang/test/Interpreter/const.cpp
@@ -1,6 +1,6 @@
 // UNSUPPORTED: system-aix
 // see https://github.com/llvm/llvm-project/issues/68092
-// XFAIL: system-windows
+// XFAIL: target={{.*}}-windows-msvc
 
 // RUN: cat %s | clang-repl | FileCheck %s
 // RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s


        


More information about the cfe-commits mailing list