[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

[Derek Schuff via Phabricator via cfe-commits]

dschuff accepted this revision.
dschuff added a comment.

otherwise LGTM



================
Comment at: lld/wasm/Options.td:196
 
+defm keep_section: Eq<"keep-section",
+     "Preserve a section even when --strip-all is given.  This is useful for compiler drivers such as clang or emcc that, for example, depend on the features section for post-link processing.">;
----------------
dschuff wrote:
> Can this flag be used more than once? From the code it looks like maybe it can, but the description should maybe say that and there should be a test (probably I should have written one for objcopy/strip too)
Should this description also say that keep-section can be used more than once? or is there some other way to know that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149917/new/

https://reviews.llvm.org/D149917