[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

Vassil Vassilev via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 1 07:37:18 PDT 2023


================
@@ -56,26 +69,135 @@ class ReplCompletionConsumer : public CodeCompleteConsumer {
   std::shared_ptr<GlobalCodeCompletionAllocator> CCAllocator;
   CodeCompletionTUInfo CCTUInfo;
   std::vector<std::string> &Results;
+  ReplCodeCompletion &CC;
+};
+
+class CompletionContextHanndler {
+protected:
+  CodeCompletionContext CCC;
+  std::vector<std::string> &Results;
+
+public:
+  CompletionContextHanndler(CodeCompletionContext CCC,
+                            std::vector<std::string> &Results)
+      : CCC(CCC), Results(Results) {}
+  virtual void handleDeclaration(const CodeCompletionResult &Result) {}
+  virtual void handleKeyword(const CodeCompletionResult &Result) {}
+  virtual void handlePattern(const CodeCompletionResult &Result) {}
+  virtual void handleMacro(const CodeCompletionResult &Result) {}
+};
+
+class DotMemberAccessHandler : public CompletionContextHanndler {
+public:
+  DotMemberAccessHandler(CodeCompletionContext CCC,
+                         std::vector<std::string> &Results)
+      : CompletionContextHanndler(CCC, Results) {}
+  void handleDeclaration(const CodeCompletionResult &Result) override {
+    if (auto *ID = Result.Declaration->getIdentifier()) {
+      if (const auto *Fun = llvm::dyn_cast<CXXMethodDecl>(Result.Declaration)) {
+        if (Fun->getParent()->getCanonicalDecl() ==
+            CCC.getBaseType()->getAsCXXRecordDecl()->getCanonicalDecl()) {
+          LLVM_DEBUG(llvm::dbgs() << "[In HandleCodeCompleteDOT] Name : "
+                                  << ID->getName() << "\n");
+          Results.push_back(ID->getName().str());
+        }
+      }
+    }
----------------
vgvassilev wrote:

```suggestion
    if (!Result.Declaration->getIdentifier())
      return;
    if (!isa<CXXMethodDecl>(Result.Declaration))
      return;
    const auto *Fun = cast<CXXMethodDecl>(Result.Declaration)
    if (Fun->getParent()->getCanonicalDecl() ==
        CCC.getBaseType()->getAsCXXRecordDecl()->getCanonicalDecl()) {
       LLVM_DEBUG(llvm::dbgs() << "[In HandleCodeCompleteDOT] Name : "
                               << ID->getName() << "\n");
          Results.push_back(ID->getName().str());
      }
```

This would help with the indentation, please run clang-format on it.

https://github.com/llvm/llvm-project/pull/67349


More information about the cfe-commits mailing list