[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 31 11:10:12 PDT 2023


================
@@ -279,12 +279,13 @@ class DefaultIntArgument<string name, int default> : IntArgument<name, 1> {
 
 // This argument is more complex, it includes the enumerator type name,
 // a list of strings to accept, and a list of enumerators to map them to.
-class EnumArgument<string name, string type, list<string> values,
+class EnumArgument<string name, string type, bit ext, list<string> values,
----------------
erichkeane wrote:

I agree about the magic-ness, that seems like it would be confusing quick.  I too hate lists of bools, and wish we could replace these with enums, but I haven't been able to find the time to hack that sort of thing into the tablegen.

https://github.com/llvm/llvm-project/pull/70835


More information about the cfe-commits mailing list