[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Shafik Yaghmour via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 30 13:52:05 PDT 2023


================
@@ -6431,7 +6431,7 @@ static bool HandleConstructorCall(const Expr *E, const LValue &This,
       // Non-virtual base classes are initialized in the order in the class
       // definition. We have already checked for virtual base classes.
       assert(!BaseIt->isVirtual() && "virtual base for literal type");
-      assert(Info.Ctx.hasSameType(BaseIt->getType(), BaseType) &&
+      assert(Info.Ctx.hasSameUnqualifiedType(BaseIt->getType(), BaseType) &&
----------------
shafik wrote:

This looks right to me but CC @zygoloid who originally added this code.

https://github.com/llvm/llvm-project/pull/70594


More information about the cfe-commits mailing list