[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 30 06:52:36 PDT 2023


================
@@ -274,20 +274,27 @@ class DefaultIntArgument<string name, int default> : IntArgument<name, 1> {
 }
 
 // This argument is more complex, it includes the enumerator type name,
-// a list of strings to accept, and a list of enumerators to map them to.
-class EnumArgument<string name, string type, list<string> values,
+// a list of possible values, and a list of enumerators to map them to.
+class EnumArgument<string name, string type, bit is_string, list<string> values,
----------------
erichkeane wrote:

Instead of Modifying `EnumArgument` to support a string mode, you should create a `UnevaluatedStringArgument` type and leave `EnumArgument` alone.

https://github.com/llvm/llvm-project/pull/68550


More information about the cfe-commits mailing list