https://github.com/antiagainst requested changes to this pull request. Thanks again for the contribution! A couple of comments inlined. My main concern is the duplication of `spirv.target` attribute. We should avoid the duplication and confusion there. https://github.com/llvm/llvm-project/pull/69949