[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

[Nick Desaulniers via cfe-commits]

================
@@ -1358,6 +1359,8 @@ class ConstExprEmitter :
   }
 
   llvm::Constant *VisitStringLiteral(StringLiteral *E, QualType T) {
+    if (!isa<ConstantArrayType>(T.getDesugaredType(CGM.getContext())))
----------------
nickdesaulniers wrote:

Alternatively this could be:

`if (isa<LValueReferenceType>)`

any preference/thoughts @efriedma-quic ?

https://github.com/llvm/llvm-project/pull/70366