[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 26 06:42:27 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-driver
Author: Natalie Chouinard (sudonatalie)
<details>
<summary>Changes</summary>
This test has been failing since the SPIR-V backend started failing explicitly on unsupported shader types. Switched this test to a compute shader since it is currently the only type supported.
---
Full diff: https://github.com/llvm/llvm-project/pull/70330.diff
1 Files Affected:
- (modified) clang/test/Driver/hlsl-lang-targets-spirv.hlsl (+3-3)
``````````diff
diff --git a/clang/test/Driver/hlsl-lang-targets-spirv.hlsl b/clang/test/Driver/hlsl-lang-targets-spirv.hlsl
index ff29f143ba1dc8e..e04d71263770bbb 100644
--- a/clang/test/Driver/hlsl-lang-targets-spirv.hlsl
+++ b/clang/test/Driver/hlsl-lang-targets-spirv.hlsl
@@ -2,8 +2,8 @@
// Supported targets
//
-// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s
-// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s
+// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s
+// RUN: %clang -target spirv-unknown-shadermodel6.2-compute %s -S -o /dev/null 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s
// Empty shader model
//
@@ -27,5 +27,5 @@
// CHECK-NO-ENV: error: shader stage is required in target '{{.*}}' for HLSL code generation
// CHECK-BAD-ENV: error: shader stage '{{.*}}' in target '{{.*}}' is invalid for HLSL code generation
-[shader("pixel")]
+[shader("compute"), numthreads(1,1,1)]
void main() {}
``````````
</details>
https://github.com/llvm/llvm-project/pull/70330
More information about the cfe-commits
mailing list