[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)
Vassil Vassilev via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 24 03:41:31 PDT 2023
================
@@ -617,24 +617,27 @@ void ASTDeclReader::VisitDecl(Decl *D) {
Reader.getContext());
}
D->setLocation(ThisDeclLoc);
- D->InvalidDecl = Record.readInt();
- if (Record.readInt()) { // hasAttrs
+
+ uint64_t DeclBits = Record.readInt();
+ D->InvalidDecl = DeclBits & 0x1;
+ D->setImplicit(DeclBits & (1 << 2));
+ D->Used = (DeclBits >> 3) & 0x1;
+ IsDeclMarkedUsed |= D->Used;
+ D->setReferenced(DeclBits & (1 << 4));
+ D->setTopLevelDeclInObjCContainer(DeclBits & (1 << 5));
+ D->setAccess((AccessSpecifier)((DeclBits >> 6) & 0x3));
+ D->FromASTFile = true;
+ auto ModuleOwnership = (Decl::ModuleOwnershipKind)((DeclBits >> 8) & 0x7);
----------------
vgvassilev wrote:
Is there a way to improve the API avoiding these magic constants? I suspect this would be difficult to read and maintain.
https://github.com/llvm/llvm-project/pull/69287
More information about the cfe-commits
mailing list