[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 21 22:08:09 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 0b7ae41b23fc05c2ac3afc8566b8a923d7f76c45 e2c5b620b7d527dc0ba886122a0a510c058dcd17 -- clang/lib/Driver/ToolChains/Solaris.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Driver/ToolChains/Solaris.cpp b/clang/lib/Driver/ToolChains/Solaris.cpp
index 0848441c3dbc..cd94616eef3e 100644
--- a/clang/lib/Driver/ToolChains/Solaris.cpp
+++ b/clang/lib/Driver/ToolChains/Solaris.cpp
@@ -168,8 +168,7 @@ void solaris::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nostartfiles,
                    options::OPT_r)) {
     if (!Args.hasArg(options::OPT_shared))
-      CmdArgs.push_back(
-          Args.MakeArgString(ToolChain.GetFilePath("crt1.o")));
+      CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crt1.o")));
 
     CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crti.o")));
 
@@ -192,8 +191,7 @@ void solaris::Linker::ConstructJob(Compilation &C, const JobAction &JA,
     // Use values-xpg4.o for -std=c90, -std=gnu90, -std=iso9899:199409.
     if (LangStd && LangStd->getLanguage() == Language::C && !LangStd->isC99())
       values_xpg = "values-xpg4.o";
-    CmdArgs.push_back(
-        Args.MakeArgString(ToolChain.GetFilePath(values_xpg)));
+    CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath(values_xpg)));
 
     const char *crtbegin = nullptr;
     if (Args.hasArg(options::OPT_shared) || IsPIE)
@@ -279,10 +277,8 @@ void solaris::Linker::ConstructJob(Compilation &C, const JobAction &JA,
       crtend = "crtendS.o";
     else
       crtend = "crtend.o";
-    CmdArgs.push_back(
-        Args.MakeArgString(ToolChain.GetFilePath(crtend)));
-    CmdArgs.push_back(
-        Args.MakeArgString(ToolChain.GetFilePath("crtn.o")));
+    CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath(crtend)));
+    CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crtn.o")));
   }
 
   ToolChain.addProfileRTLibs(Args, CmdArgs);

``````````

</details>


https://github.com/llvm/llvm-project/pull/69867


More information about the cfe-commits mailing list