[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 21 10:04:48 PDT 2023
tbaeder updated this revision to Diff 557826.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157252/new/
https://reviews.llvm.org/D157252
Files:
clang/lib/AST/ExprConstant.cpp
clang/test/Sema/builtin-memcpy.c
Index: clang/test/Sema/builtin-memcpy.c
===================================================================
--- /dev/null
+++ clang/test/Sema/builtin-memcpy.c
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 %s -fsyntax-only -verify=c
+// RUN: %clang_cc1 -x c++ %s -fsyntax-only -verify=cxx
+
+// cxx-no-diagnostics
+
+
+/// Zero-sized structs should not crash.
+int b() {
+ struct { } a[10];
+ __builtin_memcpy(&a[2], a, 2); // c-warning {{buffer has size 0, but size argument is 2}}
+ return 0;
+}
+
+#ifdef __cplusplus
+constexpr int b2() {
+ struct { } a[10];
+ __builtin_memcpy(&a[2], a, 2);
+ return 0;
+}
+static_assert(b2() == 0, "");
+#endif
Index: clang/lib/AST/ExprConstant.cpp
===================================================================
--- clang/lib/AST/ExprConstant.cpp
+++ clang/lib/AST/ExprConstant.cpp
@@ -9545,6 +9545,8 @@
// Figure out how many T's we're copying.
uint64_t TSize = Info.Ctx.getTypeSizeInChars(T).getQuantity();
+ if (TSize == 0)
+ return false;
if (!WChar) {
uint64_t Remainder;
llvm::APInt OrigN = N;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157252.557826.patch
Type: text/x-patch
Size: 1088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20231021/ff1f019d/attachment-0001.bin>
More information about the cfe-commits
mailing list