[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 20 06:04:15 PDT 2023


ChuanqiXu9 wrote:

> Is the issue with MDC's FileDeps that we are calling `makeAbsoluteAndPreferred` on the paths? Maybe we could instead move that call into `FullDependencyConsumer`. Or are there other issues?
> 
> The fact we need to add additional `MDC.IsStdModuleP1689Format` checks in this PR to prevent the normal consumer callbacks is not great. This makes MDC aware of implementation details of the specific output format.

Yes, the issue can be solved by not calling `makeAbsoluteAndPreferred`  too.  And it sounds indeed a good idea to move it to FullDependencyConsumer. Will do.



https://github.com/llvm/llvm-project/pull/69551


More information about the cfe-commits mailing list