[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

[Nathan Ridge via cfe-commits]

================
@@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef<std::string> ExtraBadChecks) {
       "-bugprone-use-after-move",
       // Alias for bugprone-use-after-move.
       "-hicpp-invalid-access-moved",
+      // Check uses dataflow analysis, which might hang/crash unexpectedly on
+      // incomplete code.
+      "-bugprone-unchecked-optional-access",
----------------
HighCommander4 wrote:

Thanks. I commented in https://github.com/clangd/clangd/issues/1337#issuecomment-1770201400 about users maybe asking for an override in the future, but for now, avoiding the much more common case of users who don't care about this crash being burned by its brittleness is definitely the more pressing concern.

https://github.com/llvm/llvm-project/pull/69427