[clang-tools-extra] fix usr rhs (PR #68329)
Sam McCall via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 18 23:14:59 PDT 2023
================
@@ -1070,6 +1063,24 @@ void USRGenerator::VisitMSGuidDecl(const MSGuidDecl *D) {
D->NamedDecl::printName(Out);
}
+void USRGenerator::VisitBaseUsingDecl(const BaseUsingDecl *D) {
+ // Add the filename when needed to disambiguate using decls from different
+ // files.
+ if (ShouldGenerateLocation(D) && GenLoc(D, /*IncludeOffset=*/false))
+ return;
+ VisitDeclContext(D->getDeclContext());
+ Out << "@UD";
+
+ // When the using-decl is resolved also print the context of the first target
----------------
sam-mccall wrote:
what does "when the using-decl is resolved" mean?
I guess "when" just means "if", but UnresolvedUsing{Value,Typename}Decl aren't BaseUsingDecls, so what kind of "unresolved" are we talking about?
If it's just broken code, I think the comment isn't needed, the intent to defensively not-crash is clear.
https://github.com/llvm/llvm-project/pull/68329
More information about the cfe-commits
mailing list