[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

Wed Oct 18 22:56:48 PDT 2023

ChuanqiXu added a comment.

In D108905#4654411 <https://reviews.llvm.org/D108905#4654411>, @MaskRay wrote:

> In D108905#4654410 <https://reviews.llvm.org/D108905#4654410>, @smeenai wrote:
>
>> In D108905#4654403 <https://reviews.llvm.org/D108905#4654403>, @ChuanqiXu wrote:
>>
>>> In D108905#4654393 <https://reviews.llvm.org/D108905#4654393>, @smeenai wrote:
>>>
>>>> In D108905#2975712 <https://reviews.llvm.org/D108905#2975712>, @rsmith wrote:
>>>>
>>>>> No decision as yet, but so far it looks very likely that we'll settle on the rule that exceptions cannot have potentially-throwing destructors, and that we should reject `throw`s of such types. I don't think that should be applied retroactively to C++98, though, because destructors were not implicitly non-throwing back then.
>>>>
>>>> Were there any updates here? This seems like a useful change for us, and I was wondering if it could be unblocked now.
>>>
>>> What @rsmith talked about is in the standard-wise. I mean, if you feel this is useful, it is possible to add an compiler option to enable this. I've filed an issue to track this: https://github.com/llvm/llvm-project/issues/57375. My plan was to make this happen this year.
>>
>> Yup, an option to enable this would be great for us.
>
> I am happy to revive the patch with an option? Any suggestion to the name? CC1 or Driver?

In our downstream, we use the name `-fdisable-exception-with-may-throw-dtor` as a Driver option.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108905/new/

https://reviews.llvm.org/D108905